Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loki.secretfilter docs #1925

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Update loki.secretfilter docs #1925

merged 3 commits into from
Oct 21, 2024

Conversation

romain-gaillard
Copy link
Contributor

PR Description

Update the docs for the loki.secretfilter component with some additional information regarding secret types.

Which issue(s) this PR fixes

Notes to the Reviewer

PR Checklist

  • Documentation added

@romain-gaillard romain-gaillard self-assigned this Oct 18, 2024
@romain-gaillard romain-gaillard marked this pull request as ready for review October 18, 2024 13:05
@romain-gaillard romain-gaillard changed the title Update loki.secretfilter docs Update loki.secretfilter docs Oct 18, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions for the doc input

@clayton-cornell clayton-cornell added the type/docs Docs Squad label across all Grafana Labs repos label Oct 21, 2024
Copy link
Contributor

@clayton-cornell clayton-cornell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@clayton-cornell clayton-cornell enabled auto-merge (squash) October 21, 2024 16:20
@clayton-cornell clayton-cornell merged commit cd2dce0 into main Oct 21, 2024
17 of 18 checks passed
@clayton-cornell clayton-cornell deleted the secretfilter-docs branch October 21, 2024 16:24
@romain-gaillard
Copy link
Contributor Author

Thanks a lot for the great suggestions, @clayton-cornell !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Docs Squad label across all Grafana Labs repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants